Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: playground navigate to container #192

Merged
merged 7 commits into from
Feb 1, 2024

Conversation

axel7083
Copy link
Contributor

@axel7083 axel7083 commented Jan 30, 2024

Description

Add a button to the playground next to the start/stop to redirect the user to a container details page.

Screenshots

navigate-to-container.mp4

Related issues

Fixes #191

Tests

  • Write unit tests

@axel7083
Copy link
Contributor Author

cc @slemeur

@axel7083 axel7083 self-assigned this Jan 30, 2024
@axel7083 axel7083 requested review from benoitf and feloy January 30, 2024 12:12
@axel7083 axel7083 force-pushed the feature/navigation-to-container branch from 2a7093a to 5b82e1b Compare January 30, 2024 15:20
@axel7083 axel7083 requested a review from lstocchi January 30, 2024 15:33
@lstocchi lstocchi requested a review from mairin January 31, 2024 10:29
@lstocchi
Copy link
Contributor

Code LGTM, @mairin is there any mockup for this? does it look good for you or have any suggestions?

@axel7083 axel7083 requested a review from a team as a code owner February 1, 2024 13:44
@axel7083 axel7083 enabled auto-merge (squash) February 1, 2024 13:44
@mairin
Copy link
Member

mairin commented Feb 1, 2024

Just want to say from the UX pov I'm ok with this for now. I have a pending design change but do not want to hold this PR up over it.

@axel7083 axel7083 merged commit d927a74 into main Feb 1, 2024
3 checks passed
@axel7083 axel7083 deleted the feature/navigation-to-container branch February 1, 2024 14:18
mhdawson pushed a commit to mhdawson/podman-desktop-extension-ai-lab that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: playground should display a button to redirect user to container details page
3 participants