-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: playground navigate to container #192
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc @slemeur |
axel7083
force-pushed
the
feature/navigation-to-container
branch
from
January 30, 2024 15:20
2a7093a
to
5b82e1b
Compare
Signed-off-by: axel7083 <[email protected]>
Signed-off-by: axel7083 <[email protected]>
Signed-off-by: axel7083 <[email protected]>
Code LGTM, @mairin is there any mockup for this? does it look good for you or have any suggestions? |
Just want to say from the UX pov I'm ok with this for now. I have a pending design change but do not want to hold this PR up over it. |
lstocchi
approved these changes
Feb 1, 2024
mhdawson
pushed a commit
to mhdawson/podman-desktop-extension-ai-lab
that referenced
this pull request
Nov 22, 2024
chatbot: make bootc: add message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a button to the playground next to the start/stop to redirect the user to a container details page.
Screenshots
navigate-to-container.mp4
Related issues
Fixes #191
Tests